Accept a plain payload in log-classifier - #8599
Closed
huydhn wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
meta-cla
Bot
added
the
CLA Signed
This was referenced Aug 20, 2026
Contributor
Author
|
Closing: this was scope creep on the github-status-test migration. It rewrites the entrypoint of a lambda that backfillJobs.mjs, keep-going-call-log-classifier and github-status-test all depend on, to delete ~25 lines from a lambda that isn't live yet. gha-log-uploader (#8591) keeps synthesising the v2.0 envelope, which touches nothing in production. Still worth doing on its own: teaching log_classifier to accept a plain {job_id, repo} payload is what lets its AuthType: NONE function URL be retired, once the other three callers move off it too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Impact:
log_classifier, whose entrypoint moves from lambda_http tolambda_runtime
Risk: medium -- every caller goes through this handler
What
log_classifiernow accepts{"job_id": 123, "repo": "..."}in addition to theAPI Gateway HTTP API v2.0 request its function URL callers send. Parameter
extraction moves into
parse_request, which readsqueryStringParameters, thenrawQueryString, then top-level keys, and the handler returns the same{statusCode, headers, body, isBase64Encoded}document as before so function URLcallers see no change.
Existing callers are unaffected: backfillJobs.mjs, keep-going-call-log-classifier
and github-status-test all keep using the function URL and the v2.0 shape, which
parses_a_function_url_requestpins.